Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dump files still saved server which is comment at serverlist file #3

Open
jiucaiProductions opened this issue Dec 12, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@jiucaiProductions
Copy link

dump files still saved server which is comment at serverlist file.

when server list file is:

#server s1:8081 weight=50 max_fails=2 fail_timeout=3s;
server s2:8081 weight=50 max_fails=2 fail_timeout=3s;
server s3:8081 weight=50 max_fails=2 fail_timeout=3s;

I see dump in server which has nginx-upstream-serverlist moudle:

server s1:8081 weight=50 max_fails=2 fail_timeout=3s;
server s2:8081 weight=50 max_fails=2 fail_timeout=3s;
server s3:8081 weight=50 max_fails=2 fail_timeout=3s;

is this right ? all server list file must return some header?

@abadcafe
Copy link
Owner

The parser of serverlist in the module is not as strict as the nginx's conf parser.

So the comment symbol "#" is ignored by the parser. In other words, "#server s1:8081 weight=50 max_fails=2 fail_timeout=3s;" is equal "server s1:8081 weight=50 max_fails=2 fail_timeout=3s;".

It is ugly, but just work. I will polish this in the future.

@abadcafe abadcafe added the enhancement New feature or request label Dec 12, 2019
@jiucaiProductions
Copy link
Author

thanks, expecting your update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants