From 0adfc8214daef7a850b5d35e74efa7738b13c9d3 Mon Sep 17 00:00:00 2001 From: Mark Grothe Date: Fri, 2 Aug 2024 05:57:18 -0500 Subject: [PATCH] fix: build (#2133) --- .github/pull_request_template.md | 20 ------------------- .../WalletConnectConnector.ts | 2 +- src/libs/web3-data-provider/Web3Provider.tsx | 2 +- 3 files changed, 2 insertions(+), 22 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index faf437cbf2..d5e9b1a128 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -10,32 +10,12 @@ Add any notes here that may be helpful for reviewers. --- -## Author Checklist - -Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers. - -- [ ] The base branch is set to `main` -- [ ] The title is using [Conventional Commit](https://www.conventionalcommits.org/en/v1.0.0/) formatting -- [ ] The Github issue has been linked to the PR in the Development section -- [ ] The General Changes section has been filled out -- [ ] Developer Notes have been added (optional) - -**If the PR is ready for review:** - -- [ ] The PR is in `Open` state and not in `Draft` mode -- [ ] The `Ready for Dev Review` label has been added - ## Reviewer Checklist Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur. - [ ] End-to-end tests are passing without any errors -- [ ] Code style generally follows existing patterns - [ ] Code changes do not significantly increase the application bundle size - [ ] If there are new 3rd-party packages, they do not introduce potential security threats - [ ] If there are new environment variables being added, they have been added to the `.env.example` file as well as the pertinant `.github/actions/*` files - [ ] There are no CI changes, or they have been approved by the DevOps and Engineering team(s) -- [ ] Code changes have been quality checked in the ephemeral URL -- [ ] QA verification has been completed -- [ ] There are two or more approvals from the core team -- [ ] Squash and merge has been checked diff --git a/src/libs/web3-data-provider/WalletConnectConnector.ts b/src/libs/web3-data-provider/WalletConnectConnector.ts index a9dc9ac2e9..ed9ff553e9 100644 --- a/src/libs/web3-data-provider/WalletConnectConnector.ts +++ b/src/libs/web3-data-provider/WalletConnectConnector.ts @@ -86,7 +86,7 @@ export class WalletConnectConnector extends AbstractConnector { } } - public async getProvider(): Promise { + public async getProvider(): Promise { return this.walletConnectProvider; } diff --git a/src/libs/web3-data-provider/Web3Provider.tsx b/src/libs/web3-data-provider/Web3Provider.tsx index d44b6ca17e..512d48a3d8 100644 --- a/src/libs/web3-data-provider/Web3Provider.tsx +++ b/src/libs/web3-data-provider/Web3Provider.tsx @@ -146,7 +146,7 @@ export const Web3ContextProvider: React.FC<{ children: ReactElement }> = ({ chil setConnector(connector); // eslint-disable-next-line @typescript-eslint/no-explicit-any - if ((window as any).ethereum.isFamily) { + if ((window as any).ethereum?.isFamily) { // eslint-disable-next-line @typescript-eslint/no-explicit-any (window as any).ethereum.on('chainChanged', (chainId: string | number) => { // the injected connector relies on the networkChanged event to update the chainId,