From 85d8548aac65dc4d7d9350f38a096aac86b813de Mon Sep 17 00:00:00 2001 From: Aaron <29749331+aarnphm@users.noreply.github.com> Date: Wed, 15 Mar 2023 22:31:38 -0700 Subject: [PATCH] fix: deprecate intialization from enums for `from_sampling_strategy` Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com> --- src/whispercpp/params.cc | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/whispercpp/params.cc b/src/whispercpp/params.cc index 2f7c47d..1766631 100644 --- a/src/whispercpp/params.cc +++ b/src/whispercpp/params.cc @@ -273,6 +273,16 @@ void ExportSamplingStrategiesApi(py::module &m) { .def_static("from_strategy_type", &SamplingStrategies::from_sampling_strategy, "strategy_type"_a) + .def_static( + "from_strategy_type", + [](whisper_sampling_strategy *enum_) { + PyErr_WarnEx(PyExc_DeprecationWarning, + "'from_strategy_type' will not take an enum in " + "future release. Enum initialization should be " + "using 'from_enum' instead.", + 1); + return SamplingStrategies::from_enum(enum_); + }) .def_static("from_enum", &SamplingStrategies::from_enum, "strategy_enum"_a) .def_property(