split_target over string beginning with exactly two slashes

[cuihtlauac]

I believe the behaviour of split_target is wrong when it is passed a string which begins with exactly two slashes:

>utop-full -require digestif.c
utop # #require "dream";;
utop # Dream.split_target "aaa/bbb/ccc";;
- : string * string = ("aaa/bbb/ccc", "")
utop # Dream.split_target "/aaa/bbb/ccc";;
- : string * string = ("/aaa/bbb/ccc", "")
utop # Dream.split_target "//aaa/bbb/ccc";; (* Boom! *)
- : string * string = ("/bbb/ccc", "")
utop # Dream.split_target "///aaa/bbb/ccc";;
- : string * string = ("/aaa/bbb/ccc", "")
utop # Dream.split_target "////aaa/bbb/ccc";;
- : string * string = ("//aaa/bbb/ccc", "")
utop # Dream.split_target "/////aaa/bbb/ccc";;
- : string * string = ("///aaa/bbb/ccc", "")

[cuihtlauac]

Maybe an upstream issue:

• Uri.path broken ? mirage/ocaml-uri#167
• https://github.com/aantron/dream/blob/master/src/pure/formats.ml#L168

[aantron]

It's probably related to

dream/test/expect/pure/formats/target/target.ml

Lines 19 to 22 in 599efd5

	(* TODO A very questionable interpretation of // as leading a hostname when we
	know this is a target. There seems to be no way to work around this using
	the interface of the Uri library. *)
	decode "//abc/def";

and the test's output

dream/test/expect/pure/formats/target/target.ml

Line 37 in 599efd5

"/def" ""

and may be an upstream issue indeed. I am looking into this now. Ultimately, it should be possible to work around it by reimplementing it, even if it turns out to be an issue in Uri.

[aantron]

I've left a detailed comment about this in the issue you opened, mirage/ocaml-uri#167 (thanks for that). I suggest we wait to see if there is a fix for this in ocaml-uri soon. If not, we can work around it in Dream for the next release.