Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needed to run valet link after creating site #22

Open
jjeaton opened this issue May 24, 2017 · 5 comments
Open

Needed to run valet link after creating site #22

jjeaton opened this issue May 24, 2017 · 5 comments

Comments

@jjeaton
Copy link

jjeaton commented May 24, 2017

I'm not using valet park for all sites in a directory, so possibly that's the issue here.

After running wp valet new <sitename> I needed to cd into the <sitename> directory and run valet link <sitename> before it works.

Is this expected?

@aaemnnosttv
Copy link
Owner

Yes, the command currently assumes you're using it in a "parked" directory.

I've thought about adding the option to, or just linking it by default though. I always use it in a parked directory so I'm leaning towards the option.

@jjeaton
Copy link
Author

jjeaton commented May 24, 2017 via email

@javorszky
Copy link

Hm, if you're using it in parked mode, then that could create inconsistent sites.

$ mkdir wpvalettest
$ cd wpvalettest
$ wp valet new wpvaletfoo

Valet parked will assume the site is in https://wpvalettest.tld, yet we just set it to be https://wpvaletfoo.tld.

@aaemnnosttv
Copy link
Owner

If we were to implement the --link flag, it would be optional. By default, the command has always assumed you're using a parked directory or linking it yourself, this would just be a little quicker for those who are doing an install in a non-parked directory.

Of course the command would also link the proper directory, that's not a problem 😄

@idleberg
Copy link

Any news on a --link flag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants