Skip to content

Commit e5ab156

Browse files
authored
Merge pull request kubernetes-sigs#1717 from ricardomaraschini/remove-unecessary-assignments
chore: stop with no-op default evictor settings
2 parents a01fa87 + 6e714a2 commit e5ab156

File tree

1 file changed

+2
-30
lines changed

1 file changed

+2
-30
lines changed

pkg/framework/plugins/defaultevictor/defaults.go

Lines changed: 2 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -21,35 +21,7 @@ func addDefaultingFuncs(scheme *runtime.Scheme) error {
2121
return RegisterDefaults(scheme)
2222
}
2323

24-
// SetDefaults_DefaultEvictorArgs
25-
// TODO: the final default values would be discussed in community
24+
// SetDefaults_DefaultEvictorArgs sets the default values for the
25+
// DefaultEvictorArgs configuration.
2626
func SetDefaults_DefaultEvictorArgs(obj runtime.Object) {
27-
args := obj.(*DefaultEvictorArgs)
28-
if args.NodeSelector == "" {
29-
args.NodeSelector = ""
30-
}
31-
if !args.EvictLocalStoragePods {
32-
args.EvictLocalStoragePods = false
33-
}
34-
if !args.EvictDaemonSetPods {
35-
args.EvictDaemonSetPods = false
36-
}
37-
if !args.EvictSystemCriticalPods {
38-
args.EvictSystemCriticalPods = false
39-
}
40-
if !args.IgnorePvcPods {
41-
args.IgnorePvcPods = false
42-
}
43-
if !args.EvictFailedBarePods {
44-
args.EvictFailedBarePods = false
45-
}
46-
if args.LabelSelector == nil {
47-
args.LabelSelector = nil
48-
}
49-
if args.PriorityThreshold == nil {
50-
args.PriorityThreshold = nil
51-
}
52-
if !args.NodeFit {
53-
args.NodeFit = false
54-
}
5527
}

0 commit comments

Comments
 (0)