Skip to content

Return zero address for eth_coinbase method #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eshaan7 opened this issue Feb 22, 2025 · 3 comments · Fixed by #585
Closed

Return zero address for eth_coinbase method #527

eshaan7 opened this issue Feb 22, 2025 · 3 comments · Fixed by #585

Comments

@eshaan7
Copy link
Contributor

eshaan7 commented Feb 22, 2025

The current implementation of eth_coinbase is incorrect. This method is also not relevant to Helios.

Change the implementation to simply return the zero address to avoid crashing if somebody pings it.
@Shashwat-Nautiyal
Copy link

Hi, can i take up this issue?

@ncitron
Copy link
Collaborator

ncitron commented Mar 1, 2025

feel free

@Shashwat-Nautiyal
Copy link

Hello, please check PR #556

mw2000 added a commit to mw2000/helios that referenced this issue Apr 17, 2025
@mw2000
chore: zero address returned for eth_coinbase
bc6cdcb 
Building on comments from a16z#556, we return zero address for eth_coinbase. Closes a16z#527
@mw2000 mw2000 mentioned this issue Apr 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: zero address returned for eth_coinbase mw2000/helios
3 participants
@eshaan7 @ncitron @Shashwat-Nautiyal