fix: resolve out of sync messages in useChatSession by accessing it from the store directly

Author: a-ghorbani

src/components/Message/Message.tsx

@@ -229,7 +229,7 @@ export const Message = React.memo(
         />
         <Pressable
           onLongPress={event => {
-            ReactNativeHapticFeedback.trigger('impactMedium', hapticOptions);
+            ReactNativeHapticFeedback.trigger('impactLight', hapticOptions);
             onMessageLongPress?.(excludeDerivedMessageProps(message), event);
           }}
           onPress={event => {

src/hooks/__tests__/useChatSession.test.ts

@@ -40,7 +40,7 @@ describe('useChatSession', () => {
 
   it('should send a message and update the chat session', async () => {
     const {result} = renderHook(() =>
-      useChatSession({current: null}, [], textMessage.author, mockAssistant),
+      useChatSession({current: null}, textMessage.author, mockAssistant),
     );
 
     await act(async () => {
@@ -54,7 +54,7 @@ describe('useChatSession', () => {
   it('should handle model not loaded scenario', async () => {
     modelStore.context = undefined;
     const {result} = renderHook(() =>
-      useChatSession({current: null}, [], textMessage.author, assistant),
+      useChatSession({current: null}, textMessage.author, assistant),
     );
 
     await act(async () => {
@@ -81,7 +81,7 @@ describe('useChatSession', () => {
     }
 
     const {result} = renderHook(() =>
-      useChatSession({current: null}, [], textMessage.author, mockAssistant),
+      useChatSession({current: null}, textMessage.author, mockAssistant),
     );
 
     await act(async () => {
@@ -110,7 +110,7 @@ describe('useChatSession', () => {
     }
 
     const {result} = renderHook(() =>
-      useChatSession({current: null}, [], textMessage.author, mockAssistant),
+      useChatSession({current: null}, textMessage.author, mockAssistant),
     );
 
     await act(async () => {
@@ -150,7 +150,7 @@ describe('useChatSession', () => {
 
   it('should reset the conversation', () => {
     const {result} = renderHook(() =>
-      useChatSession({current: null}, [], textMessage.author, mockAssistant),
+      useChatSession({current: null}, textMessage.author, mockAssistant),
     );
 
     result.current.handleResetConversation();
@@ -165,7 +165,7 @@ describe('useChatSession', () => {
 
   it('should not stop completion when inferencing is false', () => {
     const {result} = renderHook(() =>
-      useChatSession({current: null}, [], textMessage.author, mockAssistant),
+      useChatSession({current: null}, textMessage.author, mockAssistant),
     );
 
     result.current.handleStopPress();
@@ -186,7 +186,7 @@ describe('useChatSession', () => {
     }
 
     const {result} = renderHook(() =>
-      useChatSession({current: null}, [], textMessage.author, mockAssistant),
+      useChatSession({current: null}, textMessage.author, mockAssistant),
     );
 
     const sendPromise = act(async () => {
@@ -232,7 +232,7 @@ describe('useChatSession', () => {
       modelStore.setActiveModel(testModel.id);
 
       const {result} = renderHook(() =>
-        useChatSession({current: null}, [], textMessage.author, mockAssistant),
+        useChatSession({current: null}, textMessage.author, mockAssistant),
       );
 
       await act(async () => {

src/hooks/useChatSession.ts

@@ -14,7 +14,6 @@ export const useChatSession = (
     createdAt: number;
     id: string;
   } | null>,
-  messages: MessageType.Any[],
   user: User,
   assistant: User,
 ) => {
@@ -101,7 +100,9 @@ export const useChatSession = (
         : []),
       ...convertToChatMessages([
         textMessage,
-        ...messages.filter(msg => msg.id !== textMessage.id),
+        ...chatSessionStore.currentSessionMessages.filter(
+          msg => msg.id !== textMessage.id,
+        ),
       ]),
     ];
 

src/screens/ChatScreen/ChatScreen.tsx

@@ -39,11 +39,9 @@ export const ChatScreen: React.FC = observer(() => {
     null,
   );
   const l10n = React.useContext(L10nContext);
-  const messages = chatSessionStore.currentSessionMessages;
 
   const {handleSendPress, handleStopPress} = useChatSession(
     currentMessageInfo,
-    messages,
     user,
     assistant,
   );
@@ -60,7 +58,7 @@ export const ChatScreen: React.FC = observer(() => {
             : undefined
         }
         renderBubble={renderBubble}
-        messages={messages}
+        messages={chatSessionStore.currentSessionMessages}
         onSendPress={handleSendPress}
         onStopPress={handleStopPress}
         user={user}