Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

full diff <head> #69

Open
Zolmeister opened this issue Dec 22, 2015 · 5 comments
Open

full diff <head> #69

Zolmeister opened this issue Dec 22, 2015 · 5 comments

Comments

@Zolmeister
Copy link
Member

diffing the element is tricky because you don't want to re-fetch dependencies, but you still want to allow for dynamic and tags (see clay.io).
@austinhallock
Copy link

https://github.com/Zorium/zorium/blob/master/src/render.coffee#L76 allowing the link tag causes iOS UIWebview (eg Chrome) to refetch fonts with every render

@Zolmeister
Copy link
Member Author

@austinhallock it shouldn't be re-setting old values? https://github.com/Zorium/zorium/blob/master/src/render.coffee#L92

@Zolmeister
Copy link
Member Author

because the DOM does weird stuff with values (e.g. style object is DOM custom style object), should store changed (and compared) values on custom node prop (e.g. _zorium_props)
Either that, or see how virtual-dom handles it (diff code), or try to use virtual-dom to diff each element

Zolmeister added a commit that referenced this issue Jan 21, 2016
@Zolmeister
render: fix DOM object mutation, addressing comments in #69
f0701b4
@austinhallock
Copy link

fyi your fix didn't fix it on iOS. Made it worse.

Previously adding https:// instead of // fixed the font reloading thing, but now it always does it (even with the https://) on UIWebview.

It's comparing VirtualNode to 'text/css' in https://github.com/Zorium/zorium/blob/master/src/render.coffee#L101

Zolmeister added a commit that referenced this issue Jan 22, 2016
@Zolmeister
render: fix head diffing value comparison, really ought to add tests,…
31f7da8 
… ref #69
@Zolmeister
Copy link
Member Author

@austinhallock fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Zolmeister @austinhallock