addressed pr comments

Author: vishnuszipstack

backend/prompt_studio/prompt_studio_v2/migrations/0005_alter_toolstudioprompt_required.py

@@ -0,0 +1,24 @@
+# Generated by Django 4.2.1 on 2024-12-20 06:35
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("prompt_studio_v2", "0004_alter_toolstudioprompt_required"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="toolstudioprompt",
+            name="required",
+            field=models.CharField(
+                blank=True,
+                choices=[("all", "All values required"), ("any", "Any value required")],
+                db_comment="Field to store weather the values all values or any         values required. This is used for HQR, based on the value approve or finish         review",
+                default=None,
+                null=True,
+            ),
+        ),
+    ]

backend/prompt_studio/prompt_studio_v2/models.py

@@ -93,11 +93,13 @@ class RequiredType(models.TextChoices):
         unique=False,
     )
     required = models.CharField(
-        max_length=3,
         choices=RequiredType.choices,
         null=True,  # Allows the field to store NULL in the database
         blank=True,  # Allows the field to be optional in forms
         default=None,  # Sets the default value to None
+        db_comment="Field to store weather the values all values or any \
+        values required. This is used for HQR, based on the value approve or finish \
+        review",
     )
     is_assert = models.BooleanField(default=False)
     active = models.BooleanField(default=True, null=False, blank=False)

prompt-service/src/unstract/prompt_service/helper.py

@@ -396,24 +396,3 @@ def extract_table(
     except table_extractor["exception_cls"] as e:
         msg = f"Couldn't extract table. {e}"
         raise APIError(message=msg)
-
-
-def add_required_field(
-    required_fields: dict[str, str], key: str, required: str
-) -> dict[str, str]:
-    """
-    Add or update a required field in the required_fields dictionary.
-
-    Args:
-        required_fields (Dict[str, str]): The dictionary
-        containing existing required fields,
-        where keys are field names and values are boolean flags.
-        key (str): The field key to add or update in the dictionary.
-        required (str): A indicating whether the
-        all/any values in field is required.
-
-    Returns:
-        Dict[str, str]: The updated dictionary of required fields.
-    """
-    required_fields[key] = required
-    return required_fields

prompt-service/src/unstract/prompt_service/main.py

@@ -11,7 +11,6 @@
 from unstract.prompt_service.constants import RunLevel
 from unstract.prompt_service.exceptions import APIError, ErrorResponse, NoPayloadError
 from unstract.prompt_service.helper import (
-    add_required_field,
     construct_and_run_prompt,
     extract_table,
     extract_variable,
@@ -125,11 +124,10 @@ def prompt_processor() -> Any:
     # TODO: Rename "output" to "prompt"
     for output in prompts:  # type:ignore
         variable_names.append(output[PSKeys.NAME])
-        metadata[PSKeys.REQUIRED_FIELDS] = add_required_field(
-            metadata[PSKeys.REQUIRED_FIELDS],
-            output[PSKeys.NAME],
-            output.get(PSKeys.REQUIRED, None),
+        metadata[PSKeys.REQUIRED_FIELDS][output[PSKeys.NAME]] = output.get(
+            PSKeys.REQUIRED, None
         )
+
     for output in prompts:  # type:ignore
         prompt_name = output[PSKeys.NAME]
         prompt_text = output[PSKeys.PROMPT]