This repository was archived by the owner on Aug 27, 2025. It is now read-only.
[master] Refactor CheckContractTxnShards to always send contract call/creation to DS #3532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SHARD unless you are actually a lookup or archival node.
github-actions
bot
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the horrible code duplication resulting from our earlier approach of not touching the existing Scilla related codebase.
This is an alternative to #3530, which fixes the problem but this refactoring tries to eliminate all confusion about sharding and smart contracts.
Description
Backward Compatibility
Review Suggestion
Status
Implementation
Integration Test (Core Team)