-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement generic addNodes and addEdges #363
Conversation
Codecov Report
@@ Coverage Diff @@
## master #363 +/- ##
==========================================
+ Coverage 97.43% 97.50% +0.06%
==========================================
Files 55 55
Lines 8978 9179 +201
==========================================
+ Hits 8748 8950 +202
+ Misses 230 229 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new syntax is fantastic. Thanks @sbaldu !
Thanks, I'm glad you like it. |
Looks like it's choking on the fold expression. Lemme look into it. Update: Looks like it's a compiler bug: https://stackoverflow.com/questions/66070211/when-are-fold-expressions-as-template-parameters-allowed I've verified by compiling against C++20 at-desk. Thanks again Microsoft... |
Write generic
addEdges
andaddNodes
methods taking an arbitrary number of parameters (issue #361).