Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement generic addNodes and addEdges #363

Merged
merged 7 commits into from
Oct 9, 2023

Conversation

sbaldu
Copy link
Collaborator

@sbaldu sbaldu commented Oct 8, 2023

Write generic addEdges and addNodes methods taking an arbitrary number of parameters (issue #361).

@sbaldu sbaldu marked this pull request as draft October 8, 2023 09:33
@github-actions github-actions bot added test Something about test core something about core labels Oct 8, 2023
@sbaldu sbaldu linked an issue Oct 8, 2023 that may be closed by this pull request
@ghost
Copy link

ghost commented Oct 8, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #363 (c2d7ef5) into master (916e6cc) will increase coverage by 0.06%.
The diff coverage is 99.51%.

❗ Current head c2d7ef5 differs from pull request most recent head 35655e7. Consider uploading reports for the commit 35655e7 to get more accurate results

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
+ Coverage   97.43%   97.50%   +0.06%     
==========================================
  Files          55       55              
  Lines        8978     9179     +201     
==========================================
+ Hits         8748     8950     +202     
+ Misses        230      229       -1     
Flag Coverage Δ
unittests 97.50% <99.51%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
include/CXXGraph/Graph/Graph.hpp 95.58% <100.00%> (+0.02%) ⬆️
test/GraphTest.cpp 99.18% <99.48%> (+0.16%) ⬆️

... and 1 file with indirect coverage changes

@sbaldu sbaldu marked this pull request as ready for review October 8, 2023 21:03
@sbaldu sbaldu closed this Oct 8, 2023
@sbaldu sbaldu reopened this Oct 8, 2023
Copy link
Collaborator

@nrkramer nrkramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new syntax is fantastic. Thanks @sbaldu !

@sbaldu
Copy link
Collaborator Author

sbaldu commented Oct 8, 2023

This new syntax is fantastic. Thanks @sbaldu !

Thanks, I'm glad you like it.
I see that the windows cmake build workflow is failing, and I honestly don't know why, since the one on linux runs fine. Any ideas?

@nrkramer
Copy link
Collaborator

nrkramer commented Oct 8, 2023

I see that the windows cmake build workflow is failing

Looks like it's choking on the fold expression. Lemme look into it.

Update: Looks like it's a compiler bug: https://stackoverflow.com/questions/66070211/when-are-fold-expressions-as-template-parameters-allowed

I've verified by compiling against C++20 at-desk. Thanks again Microsoft...

@sbaldu

@ZigRazor ZigRazor merged commit db7a3cd into ZigRazor:master Oct 9, 2023
23 of 26 checks passed
@sbaldu sbaldu deleted the feature_generic_addNode branch October 9, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core something about core test Something about test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add generic addNode and addEdge overloads
3 participants