fixed make install, close #335 #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
test
|
I have closed #353 because it had some internal issues with the branch syncing with github. |
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 55 55
Lines 8745 8745
=======================================
Hits 8524 8524
Misses 221 221
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sbaldu
requested review from
sbaldu and
ZigRazor
and removed request for
sbaldu
sbaldu
approved these changes
Sep 28, 2023
ZigRazor
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, we can build the project and run
sudo make installto install this header library.$(project_dir)/includeto$(project_dir)/include/CXXGraph$(project_dir)/include/CXXGraph$(project_dir)/test,$(project_dir)/examples,$(project_dir)/benchmarkWhy do we need to do this and what's the need?
When installing without this fix, it placed the files and folders of
$(project_dir)/include, which areCXXGraphConfig.hCXXGraph.hppEdgeGraphNodePartitioningUtilityinto/usr/local/include, hence populating it with a lot of folders.Now with the help of this fix:
we get one single folder
/usr/local/include/CXXGraphin which every file is located.and can now run this library codes without including a path.
What has been changed?
#include "CXXGraph.hpp"with#include "CXXGraph/CXXGraph.hpp", when running using the include folder#include <CXXGraph/CXXGraph.hpp>when library is successfully installedNote
I have used
#include "CXXGraph/CXXGraph.hpp", instead of#include <CXXGraph/CXXGraph.hpp>, in the whole codebase here, because we don't know a user has installed the library or not, for the running our provided tests, examples, and benchmarks.using
#include "CXXGraph/CXXGraph.hpp"and correct CMakeListstarget_include_directorieswe can always compile is successfully, for tests, benchmarks and examples.@ZigRazor