Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tests on BFS Algorithm #59

Open
ZigRazor opened this issue Sep 30, 2021 · 8 comments
Open

Add Tests on BFS Algorithm #59

ZigRazor opened this issue Sep 30, 2021 · 8 comments
Assignees
@sharduld1908
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest hacktoberfest issue help wanted Extra attention is needed Priority:Low Priority Label for low priority issue test Something about test
Milestone
In-Depth Tests

Comments

@ZigRazor
Copy link
Owner

There is the necessity to write more test on BFS Algorithm.
Specialy on limit case.
Any contribution is appreciated.
@ZigRazor ZigRazor added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers test Something about test Priority:Low Priority Label for low priority issue hacktoberfest hacktoberfest issue labels Sep 30, 2021
@ZigRazor ZigRazor added this to the In-Depth Tests milestone Sep 30, 2021
@ZigRazor ZigRazor pinned this issue Oct 1, 2021
@singhsanskar202
Copy link

I would like to contribute.

@ZigRazor
Copy link
Owner Author

ZigRazor commented Oct 7, 2021

I assign it to you

@ZigRazor ZigRazor unpinned this issue Oct 12, 2021
@ZigRazor
Copy link
Owner Author

Hi @singhsanskar202 do you have news about this issue?

@ZigRazor
Copy link
Owner Author

Deassigned due to inactivity

@sharduld1908
Copy link

Hi. Can I contribute to this issue?

@sharduld1908
Copy link

Hi looks like there already is BFSTest.cpp added. Do you guys want to add any new test cases to it?

@ZigRazor
Copy link
Owner Author

Yes @sharduld1908

@divingPelican divingPelican mentioned this issue Jun 1, 2024
Open
@divingPelican
Copy link

divingPelican commented Jun 1, 2024 •
edited
Loading

@ZigRazor I have created a new pull request #446 addressing this.
I have added the test cases assuming parallel edges should work but there is an issue in it.
If you look at the test cases 15 and 16 they have the exact same graph but the only difference is the order in which I add the directed and undirected edges in the edgeSet. case 15 passes but case 16 fails.
Similar issue with the case 17 and 18 but with concurrency BFS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharduld1908 sharduld1908

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest hacktoberfest issue help wanted Extra attention is needed Priority:Low Priority Label for low priority issue test Something about test
Projects
None yet
Milestone
In-Depth Tests
Development

No branches or pull requests
4 participants
@ZigRazor @divingPelican @sharduld1908 @singhsanskar202