Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CPM which is based on CMake's Fetch_Content module in the project #424

Open
ZigRazor opened this issue Apr 30, 2024 · 1 comment
Open
Labels
development Development of new Functionalities enhancement New feature or request good first issue Good for newcomers hacktoberfest hacktoberfest issue help wanted Extra attention is needed Priority:High Priority Label for high priority issue

Comments

@ZigRazor
Copy link
Owner

Please add the possibility to use CPM to add the CXXGraph library to a project makefile with CPMAddPackage function

@ZigRazor ZigRazor added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers development Development of new Functionalities Priority:High Priority Label for high priority issue labels Apr 30, 2024
@nolankramer
Copy link
Collaborator

nolankramer commented Apr 30, 2024

  1. CXXGraph already supports CPM, somewhat, but it's not great:
CPMAddPackage("gh:ZigRazor/CXXGraph")
if (CXXGraph_ADDED)
    add_library(CXXGraph INTERFACE IMPORTED GLOBAL)
    target_include_directories(CXXGraph INTERFACE "${CXXGraph_SOURCE_DIR}/include")
endif()

In this instance, we will want to provide a library target for CPM users so that they don't need it create it themselves.

  1. CXXGraph doesn't support single-header inclusion yet: we need to add functionality that builds the single-header from all our headers.

@ZigRazor ZigRazor added the hacktoberfest hacktoberfest issue label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Development of new Functionalities enhancement New feature or request good first issue Good for newcomers hacktoberfest hacktoberfest issue help wanted Extra attention is needed Priority:High Priority Label for high priority issue
Projects
None yet
Development

No branches or pull requests

2 participants