Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better modular comm codes? #5395

Open
XNTEABDSC opened this issue Dec 12, 2024 · 3 comments
Open

better modular comm codes? #5395

XNTEABDSC opened this issue Dec 12, 2024 · 3 comments
Labels
backend Stuff that makes code easier to work with, without affecting the end user modding

Comments

@XNTEABDSC
Copy link
Contributor

Current modular comms codes are insane, which spent me days to debug. to make comms better, I rewrite some codes and put relatives things together.
It is in https://github.com/XNTEABDSC/Silly-Wars/tree/op-comms (not finished). If you want, I can arrange them and make a pull request

@sprunk
Copy link
Member

sprunk commented Dec 12, 2024

Splitting modules etc into their own files is generally a good idea but there's worrisome caveats, for example IIRC their arbitrary order is used to generate numerical IDs and the IDs are hardcoded in CircuitAI configs.

@sprunk sprunk added backend Stuff that makes code easier to work with, without affecting the end user modding labels Dec 12, 2024
@XNTEABDSC
Copy link
Contributor Author

Splitting modules etc into their own files is generally a good idea but there's worrisome caveats, for example IIRC their arbitrary order is used to generate numerical IDs and the IDs are hardcoded in CircuitAI configs.

change circuit ai then
I see ... , well I think we can make a hardcodedID field and sort them.

@GoogleFrog
Copy link
Contributor

Could I see a diff?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Stuff that makes code easier to work with, without affecting the end user modding
Projects
None yet
Development

No branches or pull requests

3 participants