You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
TL;DR:
The replay controls set the window Y offset based on a value calculated by window width, which causes them to hide beneath the minimap or other elements when ZK is running at ultrawide resolutions.
Someone should probably fix this properly and make the widget able to save its location after being dragged around. For now, I propose the following changes:
gui_replay_controls.lua::L119-120:
local screenWidth, screenHeight = Spring.GetViewGeometry()
local windowY = math.floor(screenHeight/8)
This will probably place the widget over the user's playerlist, but it should be draggable from there. Worst case as a dirty hack is to change the window's "right" value to something higher as well, slap it in the middle of the display, and rely on the user to relocate it every time, because it'd at least be somewhere grabbable at that point.
The text was updated successfully, but these errors were encountered:
Sounds like something to fix. Saving the location is a bit worrying since it might end up saved somewhere inaccessible. We'd probably want a type of window that doesn't save if it is too far behind another window.
Well, I think it'd be easy-ish (?) to slap some logic in there when restoring saved locations that compares the widget's current location to the screen geometry (which it already has access to) and clamping it to the inside of the window as a bare min. The widgets for overdrive, wind, and eco efficiency are able to save and restore locations, though I admit I haven't tested how they behave if they're reloaded outside the window...
RE: This discussion on discord: https://discord.com/channels/278805140708786177/432874986064052235/1316560761623023638
TL;DR:
The replay controls set the window Y offset based on a value calculated by window width, which causes them to hide beneath the minimap or other elements when ZK is running at ultrawide resolutions.
Someone should probably fix this properly and make the widget able to save its location after being dragged around. For now, I propose the following changes:
gui_replay_controls.lua::L119-120:
This will probably place the widget over the user's playerlist, but it should be draggable from there. Worst case as a dirty hack is to change the window's "right" value to something higher as well, slap it in the middle of the display, and rely on the user to relocate it every time, because it'd at least be somewhere grabbable at that point.
The text was updated successfully, but these errors were encountered: