Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All-Purpose Maintenance #1

Open
TrickyLeifa opened this issue Jun 4, 2024 · 0 comments
Open

All-Purpose Maintenance #1

TrickyLeifa opened this issue Jun 4, 2024 · 0 comments

Comments

@TrickyLeifa
Copy link
Collaborator

Akashi has some issues with readability and various other problems. It'd benefit from some maintenance.

  • There are unused variables, functions and methods. Get rid of them.
  • Some headers have so many comments that it makes quick parsing (e.g. using your eyes) of a header impossible. Moving or removing them would be appropriate.
  • Reduce dependency complexity.
    • For example, the Server shouldn't be required to be passed down the client if you want to send information to the whole client. If it's really necessary, just provide a tool to Client that would provide functionality to send packets over the network.
    • Reduce logger complexity and access.
    • Reduce database complexity and access.
  • Ensure data is accessed is one way or the other but not both.
    • For example, you may access the ipid through either the method getIpid or through the member variable m_ipid because both are public. Allowing both only increase complexity to figure out what is accessed, where and when. On top of that, with the aforementioned comments being walls of text this is harder to notice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant