You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Akashi has some issues with readability and various other problems. It'd benefit from some maintenance.
There are unused variables, functions and methods. Get rid of them.
Some headers have so many comments that it makes quick parsing (e.g. using your eyes) of a header impossible. Moving or removing them would be appropriate.
Reduce dependency complexity.
For example, the Server shouldn't be required to be passed down the client if you want to send information to the whole client. If it's really necessary, just provide a tool to Client that would provide functionality to send packets over the network.
Reduce logger complexity and access.
Reduce database complexity and access.
Ensure data is accessed is one way or the other but not both.
For example, you may access the ipid through either the method getIpid or through the member variable m_ipid because both are public. Allowing both only increase complexity to figure out what is accessed, where and when. On top of that, with the aforementioned comments being walls of text this is harder to notice.
The text was updated successfully, but these errors were encountered:
Akashi has some issues with readability and various other problems. It'd benefit from some maintenance.
getIpid
or through the member variablem_ipid
because both are public. Allowing both only increase complexity to figure out what is accessed, where and when. On top of that, with the aforementioned comments being walls of text this is harder to notice.The text was updated successfully, but these errors were encountered: