Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZO-3967: Consolidate importer metrics with label content=news, video, podcast, tts #618

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

wosc
Copy link
Member

@wosc wosc commented Feb 13, 2024

Was erledigt dieser PR?

Wir wollen getrennte Alarme schreiben können dafür, wieviele Podcasts und wieviele TTS typischerweise laufend veröffentlicht werden, damit wir mitbekommen, falls eins davon stark sinkt. Dazu wird die Metrik recent_audios umgewandelt in recent_content{content="podcast|tts|etc"} (und nebenbei gleich noch der richtige Zeitstempel last_published statt last_modified verwewendet).

postdeploy

Wenn das nach Production deployed ist, muss man https://github.com/ZeitOnline/vm-prometheus-deployment/blob/main/deployments/kustomize/rules/vivi.rules.yaml anpassen:

-      expr: vivi_recent_news_published_total == 0
+      expr: vivi_recent_content_published_total{content="news"} == 0

-      expr: vivi_recent_videos_published_total == 0
+      expr: vivi_recent_content_published_total{content="video"} == 0

Und wenn wir dann verlässliche Zahlen aus Production haben, wieviele Podcasts bzw TTS jeweils so durchlaufen, können wir dafür dann auch Alarm-Regeln schreiben.

@wosc wosc requested a review from louika February 13, 2024 13:02
@wosc wosc changed the title ZO-3967: Consolidate importer metrics into vivi_recent_content_published_total wit label content (news, video, podcast, tts) ZO-3967: Consolidate importer metrics with label content=news, video, podcast, tts Feb 13, 2024
Copy link
Contributor

@louika louika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrik Exporter für vivi erfolgreich umgebaut 👍 und jetzt gibts auch Doku 😍

collect all the metrics

@louika louika merged commit d6d7eff into main Feb 15, 2024
4 checks passed
@louika louika deleted the ZO-3967 branch February 15, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants