diff --git a/.github/workflows/nightwatch.yaml b/.github/workflows/nightwatch.yaml index b864c88440..6e6a21f128 100644 --- a/.github/workflows/nightwatch.yaml +++ b/.github/workflows/nightwatch.yaml @@ -18,20 +18,17 @@ jobs: secrets: inherit with: versions: smoketest/k8s/base/versions - # copy&paste from k8s/base and k8s/staging manifest; - # the json/shell quoting is atrocious. + # copy&paste from k8s/base and k8s/staging manifest args: | - --override-type=strategic --overrides="{\"spec\": { - \"serviceAccount\": \"baseproject\", - \"containers\": [{ - \"name\": \"nightwatch-test-$TAG\", - \"env\": [ - {\"name\": \"HTTPS_PROXY\", \"value\": \"http://static-ip-proxy.ops.zeit.de:3128\"}, - {\"name\": \"VIVI_XMLRPC_PASSWORD\", \"valueFrom\": {\"secretKeyRef\": { - \"name\": \"principals\", - \"key\": \"vivi_zeit.cms.principals_system.nightwatch\" - }}} - ] - }] }}" + --override-type=json --overrides='[ + {"op": "add", "path": "/spec/serviceAccount", "value": "baseproject"}, + {"op": "add", "path": "/spec/containers/0/env", "value": [ + {"name": "HTTPS_PROXY", "value": "http://static-ip-proxy.ops.zeit.de:3128"}, + {"name": "VIVI_XMLRPC_PASSWORD", "valueFrom": {"secretKeyRef": { + "name": "principals", + "key": "vivi_zeit.cms.principals_system.nightwatch" + }}} + ]} + ]' # deploy happens via flux (on `main` branch) diff --git a/smoketest/conftest.py b/smoketest/conftest.py index 08bbd0901a..f4f285e7c6 100644 --- a/smoketest/conftest.py +++ b/smoketest/conftest.py @@ -40,10 +40,10 @@ def config(nightwatch_config): # shorter spelling for our tests def pytest_configure(config): - config.option.prometheus_job_name = 'vivi-deployment-%s' % config.option.nightwatch_environment + config.option.prometheus_job_name = 'vivi-%s' % config.option.nightwatch_environment if config.option.prometheus_extra_labels is None: config.option.prometheus_extra_labels = [] - config.option.prometheus_extra_labels.append('project=vivi-deployment') + config.option.prometheus_extra_labels.append('project=vivi') class ViviClient: