Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key of Light / Dark - Multiple Issues #10

Open
Puremin0rez opened this issue May 31, 2020 · 3 comments
Open

Key of Light / Dark - Multiple Issues #10

Puremin0rez opened this issue May 31, 2020 · 3 comments

Comments

@Puremin0rez
Copy link

Puremin0rez commented May 31, 2020

The Key of Light currently does not work at all - and the problem becomes quite obvious when looking at this line of code: https://github.com/Zaicon/InfiniteChestsV3/blob/master/InfiniteChestsV3/InfMain.cs#L373

The check is only looking for 3091, which is the Key of Night. Key of Light, 3092, was forgotten about.

The Key of Night works, but it only works when the current zone is Corruption / Crimson. This requirement does not exist in the vanilla game, and can be once again traced down to the same line of code: https://github.com/Zaicon/InfiniteChestsV3/blob/master/InfiniteChestsV3/InfMain.cs#L373

Edit: The error with Key of Light occurred with commit 5e386ca (otherwise known as 1.4 update). The issue with key spawning being bound to zones however appears to have always existed.

@mpql
Copy link

mpql commented Jun 3, 2020

Can confirm. I might try to fork and fix this myself; does anyone have the API call handy for checking if a world has corruption or crimson?

mpql added a commit to mpql/InfiniteChestsV3 that referenced this issue Jun 3, 2020
… updates AssemblyInfo.cs to version 1.3.0.0, has my built files
mpql added a commit to mpql/InfiniteChestsV3 that referenced this issue Jun 3, 2020
… updates AssemblyInfo.cs to version 1.3.0.0, has my built files
@mpql
Copy link

mpql commented Jun 3, 2020

I believe I have fixed this issue. Here's a compiled release, if you'd like to check it out.

@Puremin0rez
Copy link
Author

I believe I have fixed this issue. Here's a compiled release, if you'd like to check it out.

Thanks! Confirmed working.

While the randomization isn't exactly vanilla, this behavior is much preferred over the existing one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants