Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add completion callback to addItems(_:items) #31

Merged
merged 1 commit into from
Dec 17, 2023
Merged

fix: Add completion callback to addItems(_:items) #31

merged 1 commit into from
Dec 17, 2023

Conversation

brn
Copy link
Contributor

@brn brn commented Dec 17, 2023

Add completion callback to internal addItems(_:items) to handle completion.
Currently always printed

Loaded 0 index items from <index name>

@ZachNagengast
Copy link
Owner

This looks great, thank you! Running tests now…

ZachNagengast
ZachNagengast approved these changes Dec 17, 2023
View reviewed changes
Copy link
Owner

@ZachNagengast ZachNagengast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition 🙏

@ZachNagengast ZachNagengast merged commit 224e95e into ZachNagengast:main Dec 17, 2023
1 check passed
@brn brn deleted the fix/add-add-items-completion-callback branch December 17, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZachNagengast ZachNagengast ZachNagengast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brn @ZachNagengast