Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After next autoflake release, grab the perf improvement #88

Closed
Zac-HD opened this issue Mar 11, 2023 · 3 comments
Closed

After next autoflake release, grab the perf improvement #88

Zac-HD opened this issue Mar 11, 2023 · 3 comments

Comments

@Zac-HD
Copy link
Owner

Zac-HD commented Mar 11, 2023

PyCQA/autoflake#232 is now merged - so the temporary fix of running isort twice can be removed as soon as a new version is released and we update the minimum required version.

(via #78 (comment))
@Cheukting
Copy link
Contributor

Cheukting commented Apr 29, 2023 •
edited
Loading

I think the fix is incorporated in v2.0.2, shall the min version be 2.0.2 or 2.1.0 (next minor release)? @Zac-HD

@Zac-HD
Copy link
Owner Author

Zac-HD commented Apr 29, 2023

Might as well be 2.1.0, shed doesn't aim for long compatibility windows (unlike Hypothesis)

@Cheukting Cheukting mentioned this issue Apr 29, 2023
Closed
@Zac-HD
Copy link
Owner Author

Zac-HD commented Mar 13, 2024

Handled in #105 🙂

@Zac-HD Zac-HD closed this as completed Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update autoflake min version to 2.1.0 Cheukting/shed
2 participants
@Zac-HD @Cheukting