Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Shouldn't ZF2 be a dependency? #75

Open
localheinz opened this issue Nov 22, 2014 · 2 comments
Open

Question: Shouldn't ZF2 be a dependency? #75

localheinz opened this issue Nov 22, 2014 · 2 comments

Comments

@localheinz
Copy link
Contributor

I see this in .travis.yml:

before_install:
 - cd test; git clone --depth=1 https://github.com/zendframework/zf2.git

meaning I can't run the tests locally unless I install ZF2.

In my opinion, this should be a dev dependency, then.

@adamlundrigan
Copy link
Contributor

@localheinz my only comment is that I would leave the existing autoloader setup in place.
@Danielss89 what do you think is the likelihood that removing the autoloader would actually break someone's app? Is there anyone at all left who's not using Composer? :P

@Danielss89
Copy link
Member

Yes, i think there's alot of people who's not using composer, but just downloading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants