Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Strict standards: ZfcBase\Module\AbstractModule::init() #71

Open
dphn opened this issue Feb 16, 2014 · 3 comments
Open

PHP Strict standards: ZfcBase\Module\AbstractModule::init() #71

dphn opened this issue Feb 16, 2014 · 3 comments

Comments

@dphn
Copy link

dphn commented Feb 16, 2014

Hi. My module class extends ZfcBase\Module\AbstractModule and implements Zend\ModuleManager\Feature\InitProviderInterface.

During testing, I see:

PHP Strict standards: Declaration of ScContent\Module::init() should be compatible with ZfcBase\Module\AbstractModule::init(Zend\ModuleManager\ModuleManager $moduleManager)

It is possible to make compatible ZfcBase\Module\AbstractModule::init() with Zend\ModuleManager\Feature\InitProviderInterface::init() ?

@excennfahnfah1976
Copy link

Hallo, I get this error : Strict Standards: Declaration of ScContent\Module::init() should be compatible with ZfcBase\Module\AbstractModule::init

@ClemensSahs
Copy link

Currently no ZF-Commons module will have a problem with that change.

But if somebody extends the ZfcBase\AbstractModule::init()method he crash his library...

Hotfix for you is to disable the Strict mode in PHP.

👍 for that change

@adamlundrigan
Copy link
Contributor

I don't even know where to start with AbstractModule. It's from the ancient times of ZF2 betas and does many bad things (mostly around module options). I would avoid using it unless you have a good reason for needing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants