fix strategy intervals bug for optimizer with incorrect intervals being returned

Author: ZENALC

algobot/interface/configuration.py

@@ -18,6 +18,7 @@
 from algobot.interface.configuration_helpers import (
     add_start_end_step_to_layout, get_default_widget, set_value)
 # noinspection PyUnresolvedReferences
+from algobot.interface.utils import get_elements_from_combobox
 from algobot.strategies import *  # noqa: F403, F401
 from algobot.strategies.strategy import Strategy
 
@@ -184,14 +185,11 @@ def helper_get_optimizer(optimizer_tab, dictionary: dict, key: str, optimizerTyp
                 del settings[key]
 
     def get_strategy_intervals_for_optimizer(self, settings: dict):
-        start = self.optimizerStrategyIntervalCombobox.currentText()
-        end = self.optimizerStrategyIntervalEndCombobox.currentText()
+        combobox = self.optimizerStrategyIntervalEndCombobox
+        intervals = get_elements_from_combobox(combobox)
+        end_index = intervals.index(combobox.currentText())
 
-        sorted_intervals = helpers.get_interval_strings()
-        start_index = sorted_intervals.index(start)
-        end_index = sorted_intervals.index(end)
-
-        settings['strategyIntervals'] = sorted_intervals[start_index: end_index + 1]
+        settings['strategyIntervals'] = intervals[:end_index + 1]
 
     def get_optimizer_settings(self) -> dict:
         """

algobot/interface/utils.py

@@ -1,4 +1,6 @@
-from PyQt5.QtWidgets import QMessageBox
+from typing import List
+
+from PyQt5.QtWidgets import QComboBox, QMessageBox
 
 
 def create_popup(parent, msg: str, title='Warning'):
@@ -24,3 +26,12 @@ def open_from_msg_box(text: str, title: str):
     msgBox.setWindowTitle(title)
     msgBox.setStandardButtons(QMessageBox.Open | QMessageBox.Close)
     return msgBox.exec_() == QMessageBox.Open
+
+
+def get_elements_from_combobox(combobox: QComboBox) -> List[str]:
+    """
+    Returns all elements from combobox provided in a list.
+    :param combobox: Combobox to get list of elements from.
+    :return: List of elements from combobox.
+    """
+    return [combobox.itemText(i) for i in range(combobox.count())]