Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize S2 UI #260

Open
PoltoS opened this issue Jun 25, 2017 · 2 comments
Open

Finalize S2 UI #260

PoltoS opened this issue Jun 25, 2017 · 2 comments
Assignees
Labels

Comments

@PoltoS
Copy link
Member

PoltoS commented Jun 25, 2017

I've made all the changes for S2 implementations.

Please merge it with develop and then to stage (should be absolutelly safe) and change those two things:

  1. https://github.com/Z-Wave-Me/ExpertUI/blob/s2/app/views/network/control/control_management.html#L132
    Move this CSS out of the template
  2. https://github.com/Z-Wave-Me/ExpertUI/blob/s2/app/views/network/control/control_management.html#L147
    Make red border for the dsk_pin input field (https://github.com/Z-Wave-Me/ExpertUI/blob/s2/app/views/network/control/control_management.html#L162) when the value is out of min-max range or not a number
@PoltoS
Copy link
Member Author

PoltoS commented Jun 25, 2017

Once done, please update the condition that shows green/red "lock" icon (in the device info list) to also account for SecurityS2 command class. I think it is also worth to show what keys were granted to a device.
There can be 4 keys:

  1. S0 (is Security interview is done)
  2. S2 Unauthenticated: if devces[N].instances[0].commandClasses[159].data.grantedKeys.S2Unauthenticated.value = true and S2 interview is done
  3. S2 Authenticated: if devces[N].instances[0].commandClasses[159].data.grantedKeys.S2Authenticated.value = true and S2 interview is done
  4. S2 Access: if devces[N].instances[0].commandClasses[159].data.grantedKeys.S2Access.value = true and and S2 interview is done

And on the Interview page we should also show this information about keys

vades pushed a commit that referenced this issue Jun 27, 2017
@vades
Copy link
Contributor

vades commented Jun 27, 2017

device-type-granted-keys
interview-granted-keys

@vades vades closed this as completed Jun 27, 2017
@vades vades reopened this Jun 27, 2017
@vades vades added the testme label Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants