Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax error in change_url not recognized? #90

Open
jedie opened this issue Dec 21, 2020 · 1 comment
Open

syntax error in change_url not recognized? #90

jedie opened this issue Dec 21, 2020 · 1 comment

Comments

@jedie
Copy link
Contributor

jedie commented Dec 21, 2020

YunoHost-Apps/pyinventory_ynh@63a8914#diff-8b4bf6fd453b044a4960771a329a995e177d9b895918c3548831eb039badfd55R38 has a syntax error:

redis_db=$(ynh_app_setting_get --app="$app" --key=redis_db

Forgotten ")" at the end of the line.

But the linter passes, see: https://github.com/YunoHost-Apps/pyinventory_ynh/runs/1565074491

@alexAubin
Copy link
Member

Eeeeeh yeah that's a bit weird that shlex (or i forgot the name of the lib we're using to parse bash) doesn't complain about it ... On the other hand the main goal is more to report for bad practices (and also good ones, sometimes 😅) than bash syntax issues :s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants