Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning on usage of IS_PACKAGE_CHECK #80

Open
maniackcrudelis opened this issue Apr 16, 2020 · 0 comments
Open

Warning on usage of IS_PACKAGE_CHECK #80

maniackcrudelis opened this issue Apr 16, 2020 · 0 comments

Comments

@maniackcrudelis
Copy link

I see too many times the solution of an if on $PACKAGE_CHECK_EXEC to pass tests on package check...

While using $PACKAGE_CHECK_EXEC can be completely relevant, this is often seen as a simple way to pass falling tests.

I thought about matching it from Package_check, but it's clearly more relevant to match it from linter.

I know of 3 different way to avoid test in package check

uname -n | grep -c 'pchecker_lxc'
env | grep -c container=lxc
$PACKAGE_CHECK_EXEC

Often used behind the name IS_PACKAGE_CHECK

A warning should be added for such an usage of ways to avoid tests.
But only warning as it can be relevant and some apps do actually need that to be tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant