Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grav admin doesn't respect yunohost permissions #164

Open
eauchat opened this issue Apr 17, 2024 · 1 comment
Open

Grav admin doesn't respect yunohost permissions #164

eauchat opened this issue Apr 17, 2024 · 1 comment

Comments

@eauchat
Copy link

eauchat commented Apr 17, 2024

Describe the bug

This is a minor issue, so feel free to close it.
By default grav seems to recommend using the following way to set permissions:

find . -type f -exec chmod 664 {} \;
find ./bin -type f -exec chmod 775 {} \;
find . -type d -exec chmod 775 {} \;
find . -type d -exec chmod +s {} \;

Grav_ynh's approach is to be more restrictive, which works and looks nice to me:

find "$install_dir" -type f -exec chmod 640 {} \;
find "$install_dir/bin" -type f -exec chmod 750 {} \;
find "$install_dir" -type d -exec chmod 750 {} \;
find "$install_dir" -type d -exec chmod +s {} \;

It all works like a charm until one starts using grav admin. The admin saves in the following way:

-rw-r--r-- someNewFile
drwxr-sr-x someNewDir

So if I translate it right it means 644 for files and 755 for directories.

It's not creating issues with site functionalities, but it would be cleaner if one could instruct the admin to set permissions like done on install. I didn't find a way to do that though, but don't know grav admin so well and there might be a functionality to do so.

Anyway just wanted to post about it for the record and in case someone has some reflections on this, but as said in the beginning, if it's not really fixable, the issue can be closed.

Context

  • I have access to my server: Through SSH, through the webadmin
  • Are you in a special context or did you perform some particular tweaking on your YunoHost instance?: no
  • YunoHost version: 11.2.10.3
  • Grav_ynh version: 1.7.44~ynh1
@tituspijean
Copy link
Member

Let's add here the discussion we had on files permissions: #163 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants