Fixes OATH create credential regression bug where a ':' would be added to the account name if the optional issuer was not present.

jensutbult · jensutbult · commit 7ccb5228f05f · 2024-10-21T09:31:43.000+02:00
diff --git a/YubiKit/YubiKit/Connections/Shared/Sessions/OATH/YKFOATHCredentialUtils.m b/YubiKit/YubiKit/Connections/Shared/Sessions/OATH/YKFOATHCredentialUtils.m
@@ -33,7 +33,7 @@ + (NSString *)keyFromAccountName:(NSString *)name issuer:(NSString *)issuer peri
     if (type == YKFOATHCredentialTypeTOTP && period != YKFOATHCredentialDefaultPeriod) {
         [accountId appendFormat:@"%ld/", (unsigned long)period];
     }
-    if (issuer != nil) {
+    if (issuer != nil && issuer.length > 0) {
         [accountId appendFormat:@"%@:", issuer];
     }
     [accountId appendString:name];

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ + (NSString )keyFromAccountName:(NSString )name issuer:(NSString *)issuer peri`
`33`	`33`	`if (type == YKFOATHCredentialTypeTOTP && period != YKFOATHCredentialDefaultPeriod) {`
`34`	`34`	`[accountId appendFormat:@"%ld/", (unsigned long)period];`
`35`	`35`	`}`
`36`		`- if (issuer != nil) {`
	`36`	`+ if (issuer != nil && issuer.length > 0) {`
`37`	`37`	`[accountId appendFormat:@"%@:", issuer];`
`38`	`38`	`}`
`39`	`39`	`[accountId appendString:name];`