Skip to content
This repository was archived by the owner on Oct 4, 2022. It is now read-only.
This repository was archived by the owner on Oct 4, 2022. It is now read-only.

Cleanup yoastseo package leftovers #431

Open
@igorschoester

Description

@igorschoester

Explanation

The yoastseo package went through some changes like moving to the monorepo and being built with babel.
But some of the things no longer used are still there...

  • Looking at grunt/config/aliases.yaml:
    • build - I don't think this is used anymore, please verify. If not then the called tasks can also be removed:
      • build:css
      • build:translations
      • default -> the build step
    • build:browserified

This leads to more adjustments of tasks, please follow the threads. For example the css entry can be removed from the grunt/config/copy.js file if the build:css is no longer there.
But also they use packages that can also be removed. For example the grunt-browserified.

  • There is a css folder, which I doubt is used anywhere. But if it is, it should probably not be used. So that means the whole CSS chain can go.

  • The examples/browserified can go (the grunt task above and packages too of course).

  • Most likely the languages folder can go too. To my knowledge we build the translations in wordpress-seo. And there is no need to have them in this package.

  • templates folder should no longer be used I reckon. Perhaps it still is, but that would then be because of other technical debt. Please find out and follow the chain.

  • start script in the package.json can be removed.

  • browserify entry in the package.json can be removed.

  • Not sure if we use istanbul still. Maybe in Travis? What is it? See: https://istanbul.js.org/

  • inch.json - No idea, most likely not. What is it? See: https://inch-ci.org/help

  • The dependencies probably have quite a lot of things that are no longer used.

Technical decisions

Feedback?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions