Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete translation #37

Open
elmar69 opened this issue Oct 9, 2023 · 4 comments
Open

Incomplete translation #37

elmar69 opened this issue Oct 9, 2023 · 4 comments

Comments

@elmar69
Copy link

elmar69 commented Oct 9, 2023

I'm using German translation.
The grant-access dialog is only partly translated:
Title and Buttons are translated, The Main Question and the checkbox-label are not.

How can I fix that?

@buckybytes
Copy link
Contributor

The translations are apparently in the main MeshCentral project. If you'd still like this addressed, I can do the legwork, but I don't speak German. If you'd like to give me your native-speaker version of what each bit of English should translate to in German, I can give it a try.

@elmar69
Copy link
Author

elmar69 commented Mar 18, 2024

Here are the translations with Username "ElmarHaneke":
User "ElmarHaneke" is requesting remote desktop control of this computer. Click allow to grant access.
Der Benutzer "ElmarHaneke" möchte eine Fernsteuerung Ihres Bildschirmes durchführen. Klicken Sie auf "Erlauben", um den Zugriff zu gestatten.

Auto-accpt all requests for next 5 minutes.
Weitere Anfragen in den nächsten 5 Minuten automatisch gestatten.

User "ElmarHaneke" is requesting remote terminal control of this computer. Click allow to grant access.
Der Benutzer "ElmarHaneke" möchte eine Eingabeaufforderung ihres Rechners öffnen. Klicken Sie auf "Erlauben", um den Zugriff zu gestatten.

User "ElmarHaneke" is requesting access to all files on this computer. Click allow to grant access.
Der Benutzer "ElmarHaneke" möchte Zugriff auf alle Dateien dieses Rechners haben. Klicken Sie auf "Erlauben", um den Zugriff zu gestatten.

@elmar69
Copy link
Author

elmar69 commented Mar 18, 2024

Another untranslated message appears on closing:

Disconnect from server and close?
Serververbindung schließen und Programm beenden?

@buckybytes
Copy link
Contributor

It appears as if these strings don't use the translation file at all, so there will be a little internationalization work to be done in the code. I'm leaving this as a reference for when I circle back around.

parent.askForConsent(this, "User \"{0}\" is requesting remote terminal control of this computer. Click allow to grant access.", protocol, sessionLoggingUserName);

So don't go looking in the main translate.json for these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants