Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sigmoid is missing in QuestionAttnGRU.py #14

Open
keithhans opened this issue Oct 7, 2017 · 5 comments
Open

sigmoid is missing in QuestionAttnGRU.py #14

keithhans opened this issue Oct 7, 2017 · 5 comments
Assignees
@mahnerak @MartinXPN
Labels
bug

Comments

@keithhans
Copy link

According to equation 6 in the paper, there should be a sigmoid on K.dot(GRU_inputs, W_g1).
@mahnerak mahnerak added the bug label Oct 7, 2017
@mahnerak
Copy link
Member

mahnerak commented Oct 7, 2017

Completely agree with you. Will be fixed soon.

@keithhans
Copy link
Author

Just noticed it is also missing in SelfAttnGRU.py

@mahnerak
Copy link
Member

mahnerak commented Oct 7, 2017

We also noticed that.
Sigmoid disappeared after we switched from using Dense layers (with sigmoid activation) to SharedWeight layers.
Now I'm trying to repeat training process. We hope can get better scores after fixing this issue.

@MartinXPN MartinXPN mentioned this issue Oct 9, 2017
Merged
@mahnerak
Copy link
Member

Pull request is merged.
Not closing the issue until we compare new scores.
@MartinXPN please rerun the instruction steps from README.md

@MartinXPN
Copy link
Member

After repeating all the steps in readme the performance didn't change much. Accuracy reached up to 60% (a bit less)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mahnerak mahnerak

@MartinXPN MartinXPN

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mahnerak @keithhans @MartinXPN