Add code coverage to paasta unit test targets

danielpops · danielpops · commit 2d06b3db149c · 2022-12-08T12:08:00.000-08:00
diff --git a/.coveragerc b/.coveragerc
@@ -0,0 +1,23 @@
+[run]
+source =
+    .
+omit =
+    .tox/*
+    .paasta/*
+    tests/*
+    setup.py
+
+[report]
+
+exclude_lines =
+    # Have to re-enable the standard pragma
+    \#\s*pragma: no cover
+
+    # Don't complain if tests don't hit defensive assertion code:
+    ^\s*raise AssertionError\b
+    ^\s*raise NotImplementedError\b
+    ^\s*return NotImplemented\b
+    ^\s*raise$
+
+    # Don't complain if non-runnable code isn't run:
+    ^if __name__ == ['"]__main__['"]:$
diff --git a/.gitignore b/.gitignore
@@ -46,3 +46,6 @@ example_cluster/paasta/docker_registry.json
 general_itests/fake_etc_paasta/clusters.json
 pip-wheel-metadata
 debian/debhelper-build-stamp
+
+# Coverage artifacts
+.coverage
diff --git a/requirements-dev-minimal.txt b/requirements-dev-minimal.txt
@@ -1,5 +1,6 @@
 astroid
 asynctest
+coverage
 docutils
 flake8
 freezegun
diff --git a/requirements-dev.txt b/requirements-dev.txt
@@ -5,6 +5,7 @@ astroid==2.4.2
 asynctest==0.12.0
 Babel==2.9.1
 cfgv==2.0.1
+coverage==6.5.0
 distlib==0.3.4
 filelock==3.0.12
 flake8==3.5.0
diff --git a/tests/test_marathon_tools.py b/tests/test_marathon_tools.py
@@ -1668,7 +1668,7 @@ def test_get_marathon_client(self):
             )
             args, kwargs = client_patch.call_args
             assert "User-Agent" in kwargs["session"].headers
-            assert "py.test" in kwargs["session"].headers["User-Agent"]
+            assert "test" in kwargs["session"].headers["User-Agent"]
 
     def test_list_all_marathon_app_ids(self):
         fakeapp1 = mock.Mock(id="/fake_app1")
diff --git a/tox.ini b/tox.ini
@@ -59,7 +59,9 @@ commands =
     check-requirements -vv
     pre-commit install -f --install-hooks
     pre-commit run --all-files
-    py.test {posargs:tests}
+    coverage erase
+    coverage run -m py.test {posargs:tests}
+    coverage report -m
 
 [testenv:tests-yelpy]
 envdir = .tox/py37-linux/
@@ -72,7 +74,9 @@ commands =
     check-requirements -vv
     pre-commit install -f --install-hooks
     pre-commit run --all-files
-    py.test {posargs:tests}
+    coverage erase
+    coverage run -m py.test {posargs:tests}
+    coverage report -m
 
 [testenv:docs]
 commands =

Original file line number	Diff line number	Diff line change
`@@ -1668,7 +1668,7 @@ def test_get_marathon_client(self):`
`1668`	`1668`	`)`
`1669`	`1669`	`args, kwargs = client_patch.call_args`
`1670`	`1670`	`assert "User-Agent" in kwargs["session"].headers`
`1671`		`- assert "py.test" in kwargs["session"].headers["User-Agent"]`
	`1671`	`+ assert "test" in kwargs["session"].headers["User-Agent"]`
`1672`	`1672`
`1673`	`1673`	`def test_list_all_marathon_app_ids(self):`
`1674`	`1674`	`fakeapp1 = mock.Mock(id="/fake_app1")`