Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for standard input on audit mode #199

Open
dgzlopes opened this issue Jun 24, 2019 · 1 comment
Open

Add support for standard input on audit mode #199

dgzlopes opened this issue Jun 24, 2019 · 1 comment
Assignees
@domanchi
Labels
enhancement The issue is related to improving a certain aspect of the project. help wanted Indicates that we would like someone that’s not a maintainer to work on the issue. triaged The issue has been reviewed but has not been solved yet.

Comments

@dgzlopes
Copy link
Contributor

Supporting standard input on audit mode would make detect-secrets pipe-able and a little more Unix-like. I thought about this while commenting on #198... If I just want to audit the results, being able to pipe scan mode to audit mode and skip saving a temporary baseline would be cool.

detect-secrets scan | detect-secrets audit

Actually, audit mode supports reading a baseline from a file for getting the original_baseline, as seen here:

detect-secrets/detect_secrets/core/audit.py

Line 179 in 13575ed

def _get_baseline_from_file(filename): # pragma: no cover

@KevinHock
Copy link
Collaborator

This is a great issue, thanks for making this @dgzlopes

killuazhu pushed a commit to IBM/detect-secrets that referenced this issue May 28, 2020
@justineyster
Use DB2 detector (Yelp#199)
6c23eae 
* Use DB2 detector

Supports git-defenders/detect-secrets-discuss#190

* Simplify regex
killuazhu pushed a commit to IBM/detect-secrets that referenced this issue Jul 9, 2020
@justineyster
Use DB2 detector (Yelp#199)
758a50a 
* Use DB2 detector

Supports git-defenders/detect-secrets-discuss#190

* Simplify regex
killuazhu pushed a commit to IBM/detect-secrets that referenced this issue Sep 17, 2020
@justineyster
DB2 Detector (Yelp#194)
b88ad9e 
Supports git-defenders/detect-secrets-discuss#190

DB2 Verification (Yelp#196)

Supports git-defenders/detect-secrets-discuss#190

Use DB2 detector (Yelp#199)

Supports git-defenders/detect-secrets-discuss#190

Refactor DB2 verification for calling externally (Yelp#203)

Supports fixing bug [here](https://github.ibm.com/git-defenders/detect-secrets-stream/blob/master/detect_secrets_stream/validation/db2.py#L25)

Catch DB2 hostname, port, database from connection url (Yelp#209)

Supports git-defenders/detect-secrets-discuss#212

Timeout DB2 detector if it takes too long (Yelp#214)
@domanchi domanchi self-assigned this Nov 17, 2020
@lorenzodb1 lorenzodb1 added pending The issue still needs to be reviewed by one of the maintainers. and removed audit functionality labels Jun 13, 2022
@lorenzodb1 lorenzodb1 added help wanted Indicates that we would like someone that’s not a maintainer to work on the issue. enhancement The issue is related to improving a certain aspect of the project. triaged The issue has been reviewed but has not been solved yet. and removed pending The issue still needs to be reviewed by one of the maintainers. labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domanchi domanchi

Labels
enhancement The issue is related to improving a certain aspect of the project. help wanted Indicates that we would like someone that’s not a maintainer to work on the issue. triaged The issue has been reviewed but has not been solved yet.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@KevinHock @dgzlopes @domanchi @lorenzodb1