From c990f7ac4273e7788373b0272dcab1f16b0bca09 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Mon, 19 Dec 2022 08:20:50 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- bert/modeling_bert.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/bert/modeling_bert.py b/bert/modeling_bert.py index 937bf91..8fe86d2 100755 --- a/bert/modeling_bert.py +++ b/bert/modeling_bert.py @@ -435,7 +435,26 @@ def from_pretrained( ) ) with tarfile.open(resolved_archive_file, "r:gz") as archive: - archive.extractall(tempdir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(archive, tempdir) serialization_dir = tempdir # Load config # config_file = os.path.join(serialization_dir, CONFIG_NAME)