Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't change the cursor position by clicking the EditText or keyboard #1

Open
yisizhu520 opened this issue Nov 29, 2016 · 4 comments
Open

Comments

@yisizhu520
Copy link

The "Plus" animation is delightful and It is smooth to replace the EditText's cursor with the custom cursor. But the problem I find is that I can't change the cursor position by clicking the EditText or soft keyboard, and the actual input position has changed. I think it confuses users since input is important for a to-do list.

@igalata
Copy link
Contributor

igalata commented Nov 29, 2016

@yisizhu520 Hi! Thank you for this issue. Yes, it's really important to be able to manually change the cursor position. I'll implement it very soon. This feature will be included in the next version

@igalata
Copy link
Contributor

igalata commented Nov 30, 2016

Hello, @yisizhu520
The 1.0.1 version is available, please check it. Now you can move the cursor by clicking the EditText.
Review the changelog for more details.

@igalata igalata closed this as completed Nov 30, 2016
@igalata igalata reopened this Nov 30, 2016
@yisizhu520
Copy link
Author

Yeah, the change is what I exactly need and better than my idea. I set the textCursorDrawable attribute for the EditText:

android:textCursorDrawable="@drawable/ic_cursor_drawable"

And remove the mask view. It works but the cursor animation is not as smooth as origin custom cursor. Because the height of cursor depends on the text size of EditText and the left padding need be adjusted.
Learn a lot from the library. Thanks!

@igalata
Copy link
Contributor

igalata commented Dec 23, 2016

Hi @yisizhu520! Sorry for the delay in responding. I'll fix the issue very soon. Thanks a lot for your attention to my library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants