Added move-workspace-to-index and move-workspace-to-monitor IPC actions
#947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaLTeR
requested changes
Jan 17, 2025
src/layout/mod.rs
Outdated
| @@ -3745,6 +3745,77 @@ impl<W: LayoutElement> Layout<W> { | |||
| monitor.move_workspace_up(); | |||
| } | |||
|
|
|||
| pub fn move_workspace_to_idx(&mut self, output: Output, old_idx: usize, new_idx: usize) { | |||
There was a problem hiding this comment.
Please add an entry for this into the Op enum in the tests module at the bottom of the file for randomized tests.
There was a problem hiding this comment.
Should I also create test cases or will adding them to the enum do?
There was a problem hiding this comment.
Adding them to the enum will already suffice, but adding test cases for the tricky edge cases would be welcome. When doing that I usually comment out the relevant edge case to verify that the unit test will fail.
src/layout/mod.rs
Outdated
| monitor.move_workspace_to_idx(old_idx, new_idx); | ||
| } | ||
|
|
||
| pub fn move_workspace_to_output_by_id( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title says it all, this allows for more scriptability in workspace handling (moving specific workspaces to specific locations when needed) without relying on only moving the active workspace.
Closes #942.