Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout shifts when line-height is unset #24

Open
mia1024 opened this issue Oct 18, 2023 · 2 comments
Open

Layout shifts when line-height is unset #24

mia1024 opened this issue Oct 18, 2023 · 2 comments

Comments

@mia1024
Copy link

mia1024 commented Oct 18, 2023

Hi,

Thank you so much for this. I just want to bring to your attention that, when line-height is unset, the layout shifts wildly on hover. It looks like your website sets it to 1.5em but this doesn't come with the packaged stylesheet. See the gif below:

2023-10-18 15 18 25

Produced by the following code with version 0.2.6 of react18-json-view

import { createRoot } from "react-dom/client";
import JsonView from "react18-json-view";
import "react18-json-view/src/style.css";

createRoot(document.getElementById("root")!).render(
    <JsonView src={{ a: 1, b: { c: 2 } }} displaySize="collapsed" />,
);
@YYsuni
Copy link
Owner

YYsuni commented Oct 19, 2023

Oh, I usually use Tailwindcss in my projects , thanks for the reminder. ❤️

@YYsuni
Copy link
Owner

YYsuni commented Oct 19, 2023

I have just refined and published the new canary version. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants