Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Typing in filter/search queries results in double-keying characters (Windows 11) #30

Closed
jqnatividad opened this issue May 1, 2023 · 2 comments
Closed

Bug: Typing in filter/search queries results in double-keying characters (Windows 11) #30

jqnatividad opened this issue May 1, 2023 · 2 comments

Comments

@jqnatividad
Copy link
Contributor

So you can't effectively filter/search as characters are entered twice per one keystroke.
@YS-L
Copy link
Owner

YS-L commented May 20, 2023

Thanks for reporting! I could reproduce this in a VM.

This is caused by an issue in crossterm 0.26: crossterm-rs/crossterm#778

While the upstream fix is still in progress, one way that seems to work is to revert crossterm back to 0.25 for windows. I pushed the change in the main branch (2ef45b3). Let me know if that resolves the issue for you.

@jqnatividad
Copy link
Contributor Author

Hi @YS-L . I can confirm that this now works on Windows. Thanks!

@YS-L YS-L mentioned this issue Dec 31, 2023
Merged
joshka added a commit to joshka/csvlens that referenced this issue Dec 31, 2023
@joshka
fix: only respond to key press events
3ce170a 
Crossterm 0.26+ reports key release events on windows, which results in
the application seeing multiple events for a single key press.

See ratatui/ratatui#347 for more info.

Fixes YS-L#30
YS-L pushed a commit that referenced this issue Dec 31, 2023
@joshka
Migrate to Ratatui (#42)
fe09917 
* Migrate to Ratatui

Ratatui is a replacement for tui-rs that is actively maintained.
See https://ratatui.rs/ for more info.

* fix: only respond to key press events

Crossterm 0.26+ reports key release events on windows, which results in
the application seeing multiple events for a single key press.

See ratatui/ratatui#347 for more info.

Fixes #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jqnatividad @YS-L