[BUGFIX] Removing tags is not working properly

Author: daniellienert

Classes/Controller/ItemController.php

@@ -25,7 +25,6 @@
  ***************************************************************/
 
 use TYPO3\CMS\Core\Messaging\FlashMessage;
-use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Extbase\Utility\LocalizationUtility;
 
 /**
@@ -167,14 +166,10 @@ public function bulkUpdateAction()
         /* @var $album Tx_Yag_Domain_Model_Album */
 
         if ($album == null) {
-            $this->flashMessageContainer->add(
-                \TYPO3\CMS\Extbase\Utility\LocalizationUtility::translate('tx_yag_controller_album.noAlbumSelected', $this->extensionName), '', FlashMessage::ERROR
-            );
-
+           $this->addFlashMessage(LocalizationUtility::translate('tx_yag_controller_album.noAlbumSelected', $this->extensionName), '', FlashMessage::ERROR);
             $this->forward('list', 'ItemList');
         }
 
-
         // Do we have to change thumb for album?
         if (!$album->getThumb() instanceof Tx_Yag_Domain_Model_Item || $album->getThumb()->getUid() != $bulkEditData['album']['thumb']) {
             $thumb = $this->itemRepository->findByUid($bulkEditData['album']['thumb']);

Classes/Domain/Model/Item.php

@@ -847,9 +847,10 @@ public function getIsLandscape()
     public function setTagsFromCSV($tagsAsCSV)
     {
         $tags = array_filter(GeneralUtility::trimExplode(',', $tagsAsCSV));
+        $currentTags = clone $this->tags;
 
-        foreach ($this->tags as $tag) { /** @var Tx_Yag_Domain_Model_Tag $tag */
-            if (!in_array($tag->getName(), $tags)) {
+        foreach ($currentTags as $tag) { /** @var Tx_Yag_Domain_Model_Tag $tag */
+            if (!in_array(trim($tag->getName()), $tags)) {
                 $tag->decreaseCount();
                 $this->tags->detach($tag);
             }