Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename/Ignore duplictate feature does not work #72

Open
Gadetron opened this issue Sep 7, 2024 · 4 comments
Open

Rename/Ignore duplictate feature does not work #72

Gadetron opened this issue Sep 7, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@Gadetron
Copy link

Gadetron commented Sep 7, 2024

Describe the bug
the feature thats lets you choose what the program does with duplicate files does not work

Browser Version:
130.0 (64-bit)

To Reproduce

  1. go into the extension options and change the Setting from Rename to Ignore
  2. close the options and reopen them
  3. the setting gets reverted back to Rename while all other settings save correctly

Expected behavior
i expect the option to stay on ignore so i dont get 7 copies of the same file with ever increasing numbers

Additional context
this happens on both Brave and Firefox

@Gadetron Gadetron added the bug Something isn't working label Sep 7, 2024
@JitHubL
Copy link

JitHubL commented Sep 10, 2024

Yup can vouche for this.

@Xwilarg
Copy link
Owner

Xwilarg commented Sep 10, 2024

Hey, I made a build that should fix that, could you tell me if it works on your side?
https://github.com/Xwilarg/NHentaiDownloader/releases/tag/v2.1.8

@Gadetron
Copy link
Author

Hey, I made a build that should fix that, could you tell me if it works on your side? https://github.com/Xwilarg/NHentaiDownloader/releases/tag/v2.1.8

This fixed the issue, thanks

@Gadetron
Copy link
Author

actually related bug, it doesnt seem to respect the "ignore" option, as i am still getting numerated duplicates

@Gadetron Gadetron reopened this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants