Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent downloading of a video resolution other than that specified #87

Open
axipher opened this issue Mar 11, 2019 · 1 comment
Open

Comments

@axipher
Copy link

axipher commented Mar 11, 2019

When using the "-r 1080p" flag, the program should fail to download any resolution of a show that isn't 1080p.

The issue here is that if I've downloaded 90 episodes of an ongoing show like Boruto, then one day 1080p isn't available, then it will go through and download all 90 episodes again at whatever resolution it would find.

@axipher axipher changed the title Preent downloading of a video resolution other than that specified Prevent downloading of a video resolution other than that specified Mar 11, 2019
@Nicnl
Copy link
Contributor

Nicnl commented Mar 11, 2019

We have to test it more thoroughly
But I think I fixed this one too along with the resolution issues #86

If the requested resolution is weird from the start, it will just stop:

if resolution_to_find is None:
print('Unknown requested resolution %s' % str(resolution).lower())
return

And finally if the requested resolution is not found in the master.m3u8 file, it will also stop:

if m3u8_file_text is None:
print('Could not find the requested resolution %s in the m3u8 file\n' % file_name)
return

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants