Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State visualizations are not shown #423

Closed
1 task done
JacobHast opened this issue Jun 25, 2024 · 1 comment · Fixed by #425
Closed
1 task done

State visualizations are not shown #423

JacobHast opened this issue Jun 25, 2024 · 1 comment · Fixed by #425
Assignees
Labels
bug Something isn't working

Comments

@JacobHast
Copy link
Contributor

Before posting a bug report

  • I have searched exisisting GitHub issues to make sure the issue does not already exist.

Expected behavior

When calling .visualize_2d() I expect a state to be shown

Actual behavior

A blank box is displayed instead of a figure. If I add the keyword argument return_fig=True, the figure gets shown as desired.

image

When e.g. calling a state in a jupyter notebook, also nothing is shown:
image

Reproduces how often

100 % for me

System information

Mr Mustard: a differentiable bridge between phase space and Fock space.
Copyright 2021 Xanadu Quantum Technologies Inc.

Python version:            3.9.19
Platform info:             Windows-10-10.0.19045-SP0
Installation path:         
c:\Users\jacob\miniconda3\envs\mrmustard_dev\lib\site-packages\mrmustard
Mr Mustard version:        0.7.3
Numpy version:             1.26.4
Numba version:             0.59.1
Scipy version:             1.13.1
The Walrus version:        0.19.0
TensorFlow version:        2.16.1

Source code

No response

Tracebacks

No response

Additional information

No response

@JacobHast JacobHast added the bug Something isn't working label Jun 25, 2024
@JacobHast JacobHast changed the title State visualizations are not showb State visualizations are not shown Jun 25, 2024
@timmysilv
Copy link
Collaborator

timmysilv commented Jun 26, 2024

I've opened draft PR #425 to start fixing various issues in our new visualizations. this is a difference between Jupyter Lab/Notebooks (presumably where Sam was testing his stuff) and VS Code notebooks - it seems the latter doesn't love the HTML rendering that we're doing.

For now, my draft PR fixes the individual plots. However, it doesn't work yet for a State's default repr or the representations because those require HTML templating. State.visualize_xx should work (as if you passed return_fig=True, but I just removed that kwarg so it always does because it should).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants