Skip to content
This repository has been archived by the owner on Apr 13, 2020. It is now read-only.

Inconsistent log level used in liveness checkers #106

Open
opolsen opened this issue Feb 21, 2019 · 1 comment
Open

Inconsistent log level used in liveness checkers #106

opolsen opened this issue Feb 21, 2019 · 1 comment

Comments

@opolsen
Copy link

opolsen commented Feb 21, 2019

The log level used in the IsHealthy method seems to be inconsistent across the various liveness checkers.

There might be some reasoning behind this, but if not then I think it would be preferable to decide on which log level to use and apply that to all the liveness checkers.

Some examples:
DynamoDb, NpgSql: Logs both success and exception as debug
Oracle: Logs success as debug and exception as warning
MySql, SqlServer: Logs success as information and exception as warning

@unaizorrilla
Copy link
Collaborator

I try to work on this ASAP

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants