You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add an UnknownTransaction object that can take the place of a transaction that xrpl4j doesn't yet support. For example, loading transactions from Xahau should not blow-up (but currently they would).
The text was updated successfully, but these errors were encountered:
rsteimen
added a commit
to rsteimen/xrpl4j
that referenced
this issue
Feb 4, 2024
Hi @rsteimen - thanks for filing this issue, and for your PR. Overall, I like the problem you're solving for, and need to review your PR to consider things more deeply (e.g., I think if we want to support this kind of change, we may want to align how we handle unknown LedgerObjects with the pattern/APIs you proposed).
Overall, I don't have a timeline for you here -- but wanted to "ack" your submission. Thanks for proposing it!
Add an UnknownTransaction object that can take the place of a transaction that xrpl4j doesn't yet support. For example, loading transactions from Xahau should not blow-up (but currently they would).
The text was updated successfully, but these errors were encountered: