You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some historical AccountSet transactions set TransferRate to something larger than 2,000,000,000. This is disallowed by rippled, but only after the fix1201 amendment was enabled. Therefore, the AccountSet transactions with a large TransferFee that occurred before that amendment are valid. We have a @Value.Check on AccountSet that ensures the TransferFee field is either 0 or between 1B and 2B. We should probably get rid of this check.
Instead of getting rid of the @Value.Check, since that would hurt developer ergonomics when constructing an AccountSet, we could instead do the following:
Add a JsonNode to JsonRpcClientErrorException that is present when we are unable to deserialize a rippled result. When a developer encounters a JsonRpcClientErrorException, they can manually handle the JSON via JsonNode. Since a problem like this only occurs in historical data and can consistently be reproduced, developers should be able to trivially handle this case with the JsonNode, if they ever come across it at all.
Some historical
AccountSet
transactions setTransferRate
to something larger than 2,000,000,000. This is disallowed by rippled, but only after the fix1201 amendment was enabled. Therefore, theAccountSet
transactions with a large TransferFee that occurred before that amendment are valid. We have a@Value.Check
onAccountSet
that ensures theTransferFee
field is either 0 or between 1B and 2B. We should probably get rid of this check.Ledgers where this is a problem:
The text was updated successfully, but these errors were encountered: