Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are flakey? #2275

Closed
sublimator opened this issue Apr 15, 2023 · 9 comments
Closed

Tests are flakey? #2275

sublimator opened this issue Apr 15, 2023 · 9 comments

Comments

@sublimator
Copy link
Contributor

Are the integration tests flakey?

Suggest:

  • Increase Github Actions test runner size (more compute/memory)
  • Add a retry mechanism - simply retrying tests a few times, while not ideal, makes the tests much more useful in practice

@mvadari ?

@justinr1234
Copy link
Collaborator

@sublimator would you be able to link a couple logs or show more specific info?

@sublimator
Copy link
Contributor Author

sublimator commented Apr 15, 2023 via email

@justinr1234
Copy link
Collaborator

Got it, I’m not aware of them being flakey at the moment. The last time they were was when a faucet was going out of commission, but we fixed that.

If you notice any flakey, please drop a line on here.

@sublimator
Copy link
Contributor Author

sublimator commented Apr 15, 2023 via email

@sublimator
Copy link
Contributor Author

Here was where I started wondering:
#2273 (comment)

@sublimator
Copy link
Contributor Author

This looks related to the faucet you mentioned:

image

However, in a previous job the "browser" job failed rather than one or more of the "integration" jobs

@mvadari
Copy link
Collaborator

mvadari commented Apr 17, 2023

It's known that the tests are slightly flaky, but they appear to be failing more than usual on your PR. It's almost always because of faucet flakiness/rate limiting.

@sublimator
Copy link
Contributor Author

image

5th time's a charm!

Can see a few other PRs that seem at a glance to be victims:

@sublimator
Copy link
Contributor Author

Must have had bad luck before.
Pushes since opening this haven't yielded any issues.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants