Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor core/DatabaseCon.h #5146

Open
Bronek opened this issue Sep 20, 2024 · 0 comments
Open

Refactor core/DatabaseCon.h #5146

Bronek opened this issue Sep 20, 2024 · 0 comments
Labels
Feature Request Used to indicate requests to add new features

Comments

@Bronek
Copy link
Collaborator

Bronek commented Sep 20, 2024 •
edited
Loading

When reviewing #5135 I noticed that class ripple::DatabaseCon is overdue for some code cleanup and refactoring.

One design issue that needs to be fixed is the use of static data members. Once we have removed this static I guess we should be able to also simplify it, perhaps even move from xrpld to libxrpl
@Bronek Bronek added the Feature Request Used to indicate requests to add new features label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Used to indicate requests to add new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bronek